On Thu, Jun 17, 2010 at 1:00 PM, Jim Gay <[email protected]> wrote: > On Thu, Jun 17, 2010 at 1:42 PM, john muhl <[email protected]> wrote: >> On Thu, Jun 17, 2010 at 12:03 PM, Jim Gay <[email protected]> wrote: >>> On Thu, Jun 17, 2010 at 12:12 PM, john muhl <[email protected]> wrote: >>>> in <http://github.com/johnmuhl/radiant/commit/26668a0> i have >>>> extracted the smartypants filter from the markdown extension. the test >>>> suite is passing and everything works how it did before; e.g. using >>>> markdown still gets smartypants treatment, using smartypants skips >>>> markdown processing etc etc. >>>> >>>> is there any reason to keep them in the same extension? >>>> >>> >>> In order for Markdown to perform according to expectation, does it >>> require SmartyPants? >>> >>> In other words, could the following happen? >>> >>> Markdown + SmartyPants = good >>> SmartyPants only = good >>> Markdown only = errors on curly quotes >>> >>> Or does Markdown not care about curly quotes? >> >> here is how the filters currently work: >> >> when you choose the markdown filter: >> - rdiscount does both MD processing and SP punctuation...or >> - kramdown does both MD processing and SP punctuation >> >> when you choose the smartypants filter: >> - rubypants adds SP punctuation >> >> so in no way does using the markdown filter involve rubypants* or the >> smartypants filter; and using the smartypants filter does not involve >> using rdiscount/kramdown or the markdown filter. the two are already >> independent in this way. the change is just to put them in separate >> extensions so you could disable markdown and continue to use >> smartypants or visa-versa. >> >> * in the past the markdown filter (when using bluecloth or kramdown; >> rdiscount always had its own SP) used to invoke rubypants but the >> recent upgrade to the bundled kramdown removed that behavior >> > > That makes sense to me. > I created a repo for it here > http://github.com/radiant/radiant-smartypants_filter-extension
hope you don't mind but i renamed it radiant-smarty_pants_filter-extension for historical reasons :) <http://github.com/radiant/radiant-smarty_pants_filter-extension> > We can change the default markdown filter and add this one into the > main project. <http://github.com/johnmuhl/radiant/commit/b3844da> <http://github.com/johnmuhl/radiant/commit/d838f3d>
