On 22.10.2025 20.36, Bruno Tiago Rodrigues via radiator wrote:

Does line 1411 on radpwtst have a typo? Shouldn't it be Change-Filter- Request ?

     return "\000" x 16 if
$code eq 'Accounting-Request' ||
$code eq 'Disconnect-Request' ||
$code eq 'Change-Filter-Requet';

Hello Bruno, as Stefan already wrote, you're correct, it's a typo.

This got broken when some lines were moved in radpwtst, but fortunately those lines are no longer needed at all. Long time ago they were, but now the Radius fixed header is set differently. Initialising it to zeroes is no longer needed at this point.

The function that does the above is still used if you want to, for example, test duplicate handling and want to send the exact same request again. The function allows setting the fixed authenticator in Access-Request messages. However, zero initialisation is redundant.

In short: thanks for finding and reporting code that is no longer used and can be removed :)

Heikki

--
Heikki Vatiainen
Radiator Software, makers of Radiator
Visit radiatorsoftware.com for Radiator AAA server software

_______________________________________________
radiator mailing list
[email protected]
https://lists.open.com.au/mailman/listinfo/radiator

Reply via email to