bpa wrote:
> I should think a patch for Touch should be possible, if the issues is
> something like "unexpected" icy parameters (i.e. not StreamTitle and
> StreamURL) and/or with unusual/confusing values.
The problem with this particular failed assertion is, I suspect, this:
-streambuf_fast_read- will not return all available data if the relevant
icy data is wrapped around in the fifo buffer. A second read is required
in those circumstances. And the code only attempts one read. That's my
'defect'.
Which is not to say that "unexpected" icy parameters will not break
things elsewhere, or that a duff icy metadata length byte wouldn't
equally create difficulty.
I noticed that the ClassicFM and LBC streams can produce some relatively
large icy metadata when a track changes, or in other circumstances:
Code:
--------------------
Dec 1 03:28:53 squeezeplay: DEBUG audio.decode - streambuf_icy_filter:383
got icy metadata: StreamTitle='Leo Delibes - Sylvia - Valse
Lente';StreamUrl='';track_info='k4Smc3RhdHVzoUihQM5fxbhnpHR5cGWhVKJpZKY0MDI1MDSEpnN0YXR1c6FDoUDOX8W57KR0eXBloVSiaWSmNDU4NDc2hKZzdGF0dXOhQ6FAzl/FuuikdHlwZaFUomlkpjQwNDM1OA==';UTC='20201201T032839.656';
Nov 29 14:32:01 squeezeplay: DEBUG audio.decode - streambuf_icy_filter:383
got icy metadata:
StreamTitle='';StreamUrl='ADBREAK_LENGTH_229999:0851508063&ClashCodes={}';UTC='20201129T143125.424';
--------------------
So the odds of either of these streams triggering this assertion failure
is somewhat greater than a stream that is more modest in its icy
metadata offering. And it's not helpful that an assert failure message
ends up discarded through STDERR, I would think better redirected to the
system logger, at least pro-tem.
bpa wrote:
>
> Again the Community Radio guys might be able to help out - especially as
> it seem this problem affects a few stations.
I'll share my findings with @ralphy. I'll have to fire up my SqueezeOS
build system and test more rigorously - it lives somewhere in Amazon.
bpa wrote:
> Might be a cause of some reboots which were blamed on other things.
Agree.
------------------------------------------------------------------------
mrw's Profile: http://forums.slimdevices.com/member.php?userid=38299
View this thread: http://forums.slimdevices.com/showthread.php?t=113309
_______________________________________________
Radio mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/radio
