mrw wrote: > Thanks. I won't be offering a custom binary as I think there is an > "ordinary user" workaround available. > > Nevertheless I think that Squeezeplay does need correcting, and I've > satisfied myself that I have an appropriate patch. A second set of eyes > is always welcome. > > I've attached to this post: > > > > > - The patch that I think needs to be in Squeezeplay: > -0001-Bugfix-Incomplete-extraction-of-icy-metadata-causes-.patch.txt- - A debug/verification patch that traces proper operation: > -0002-Bugfix-icy-metadata-for-testing-only-verify-operatio.patch.txt- - A 'pokyized' version of the above that I applied to the existing > squeezeos source tree to build the test jive binary: > -00xx-poky-icy-fix-debug-version.patch.txt- > > > > > I have tested both on desktop Squeezeplay on macOS, and on a Radio > with a custom jive binary. > > Typical log output from the debug/verification version is as follows: > > Code: -------------------- > > > Dec 8 00:22:22 squeezeplay: INFO audio.decode - streambuf_icy_filter:393 ICY: Caught defect > Dec 8 00:22:22 squeezeplay: INFO audio.decode - streambuf_icy_filter:397 ICY: Stream buf read ptr should be 0, it is 0 > Dec 8 00:22:22 squeezeplay: INFO audio.decode - streambuf_icy_filter:401 ICY: Recovered from defect: icy metadata: StreamTitle='Ludwig van Beethoven - Symphony No.6 in F major Opus 68 (2)';StreamUrl='';UTC='20201208T002157.047'; > <snip> > Dec 8 04:21:34 squeezeplay: INFO audio.decode - streambuf_icy_filter:393 ICY: Caught defect > Dec 8 04:21:34 squeezeplay: INFO audio.decode - streambuf_icy_filter:397 ICY: Stream buf read ptr should be 0, it is 0 > Dec 8 04:21:34 squeezeplay: INFO audio.decode - streambuf_icy_filter:401 ICY: Recovered from defect: icy metadata: StreamTitle='Franz Schubert, Schubert Ensemble - Piano Quintet in A major D.667 (4)';StreamUrl='';UTC='20201208T042107.547'; > <snip> > Dec 8 09:12:42 squeezeplay: INFO audio.decode - streambuf_icy_filter:393 ICY: Caught defect > Dec 8 09:12:42 squeezeplay: INFO audio.decode - streambuf_icy_filter:397 ICY: Stream buf read ptr should be 0, it is 0 > Dec 8 09:12:42 squeezeplay: INFO audio.decode - streambuf_icy_filter:401 ICY: Recovered from defect: icy metadata: StreamTitle='Gustav Holst - `In the bleak mid-winter.` > -------------------- > > > > This was generated on a Radio, playing out this continuous stream: > -http://media-ice.musicradio.com/ClassicFMMP3-. > > I will add that changing -STREAMBUF_SIZE- in -streambuf.c- from 3MB > to, say, 150k, makes for a much more effective test session, because > the incidence rate is increased about 20-fold. > > Let me know if you would be interested in a receiving a PR.
Thanks for offering to create a PR but it's not necessary. I'll have a play with the patches over the weekend and can just apply the 0001-Bugfix-Incomplete-extraction-of-icy-metadata-causes-.patch file to the squeezeplay sources if everything appears to be okay. Ralphy *1*-Touch, *5*-Classics, *3*-Booms, *1*-UE Radio 'Squeezebox client builds' (https://sourceforge.net/projects/lmsclients/files/) 'donations' (https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=LL5P6365KQEXN&lc=CA&item_name=Squeezebox%20client%20builds¤cy_code=USD&bn=PP%2dDonationsBF%3abtn_donate_SM%2egif%3aNonHosted) always appreciated. ------------------------------------------------------------------------ ralphy's Profile: http://forums.slimdevices.com/member.php?userid=3484 View this thread: http://forums.slimdevices.com/showthread.php?t=113309 _______________________________________________ Radio mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/radio
