Hello all,

I'd like to get a review of ticket #3005: http://dev.rubyonrails.org/ticket/3005

This patch prevents the following kind of errors:
class QuoteLine < AR:Base
  belongs_to :quote
end

QuoteLine.find_by_product_id(312)
SELECT * FROM quote_lines WHERE product_id = <#Quote:0x39420>

#quote is defined as a method on AR:Base that quotes values.  Since it
now returns Quote objects, the SQL generates badly.

Instead, the patch will blow up during the loading of quote_line.rb:

ActiveRecord::Reflection::ReflectionNameAlreadyTaken: 'quote' is
already defined as a method in QuoteLine.  You'll have to rename your
association.
<rest of backtrace here>

The patch includes tests, and is ready for trunk.

If anybody would be willing to take a look maybe apply ?

Thanks !
--
François Beausoleil
http://blog.teksol.info/
_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core

Reply via email to