On 1/28/06, Kevin Clark <[EMAIL PROTECTED]> wrote:
> I've got a patch ready adding the pagination tests (and confirming the
> bug with :include). It depends on ticket 3606
> (http://dev.rubyonrails.org/ticket/3606) so I'll submit it as soon as
> 3606 is checked in.
> Kev
As the original author, Sam's probably the best guy to review any
tickets related to pagination. Thanks for looking into its unit
tests too.
In the meantime, I do have some questions about 3606. The use of
37signals as a fixture name breaks instantiated fixtures as @37signals
is invalid, that was a pretty simple fix though.
My main question is why the tests are defined in a huge block, it
feels a little strange to do
ActiveRecordTestRunner::Base::run(:companies) do
...
end
Rather than something like:
class ActiveRecordAssertionsControllerTest < ActiveRecordTestCase
self.fixture_path = "#{File.dirname(__FILE__)}/../fixtures/"
fixtures :companies
end
with ActiveRecordTestCase#setup taking care of the database connection/ cleanup.
Finally, sorry for the fact that none of us got back to you, we all
appreciate your work on this.
--
Cheers
Koz
_______________________________________________
Rails-core mailing list
[email protected]
http://lists.rubyonrails.org/mailman/listinfo/rails-core
