Yep looks like you got it in that change. There are some hardcore tests in
there :)
My addition had the def to_tag(options = {}) case for :time.
-Nb
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Nathaniel S. H. Brown http://nshb.net
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> -----Original Message-----
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf
> Of Bob Silva
> Sent: February 27, 2006 8:22 PM
> To: rails-core@lists.rubyonrails.org
> Subject: RE: [Rails-core] Rails 1.1 is coming
>
> Hi Nathaniel,
>
> http://dev.rubyonrails.org/ticket/3811
>
> Which includes time_select. If you want to send me your
> enhancements, I'll add them (if they aren't already in the
> patch, which is different from my plugin).
>
>
> Bob Silva
> http://www.railtie.net/
>
> > -----Original Message-----
> > From: [EMAIL PROTECTED] [mailto:rails-core-
> > [EMAIL PROTECTED] On Behalf Of Nathaniel S. H. Brown
> > Sent: Monday, February 27, 2006 8:12 PM
> > To: rails-core@lists.rubyonrails.org
> > Subject: RE: [Rails-core] Rails 1.1 is coming
> >
> > By date_helper you are referring to your time_select tag? If not, I
> > recommend getting that into the core. It is a requirement
> for anyone
> > who is using the :time column type. Currently when using the
> > field('object', 'method'), for a time column, it returns
> nothing but
> > an empty string.
> >
> > I have made enhancements to make this so, but am unsure if you have
> > already submitted this?
> >
> > -Nb
> >
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > Nathaniel S. H. Brown http://nshb.net
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> >
> > > -----Original Message-----
> > > From: [EMAIL PROTECTED]
> > > [mailto:[EMAIL PROTECTED] On
> Behalf Of Bob
> > > Silva
> > > Sent: February 27, 2006 6:25 PM
> > > To: rails-core@lists.rubyonrails.org
> > > Subject: RE: [Rails-core] Rails 1.1 is coming
> > >
> > > Here's a few more trivial patches that I run in a few
> apps without
> > > issues:
> > >
> > >
> > > http://dev.rubyonrails.org/ticket/3952 - Adds additional
> contraints
> > > to validates_numericality_of. Updated as per DHH's request to use
> > > long names instead of abbreviations.
> > >
> > > http://dev.rubyonrails.org/ticket/3506 - I just added a new patch
> > > following DHH's last recommendation.
> > >
> > > http://dev.rubyonrails.org/ticket/3691 - Adds
> :after_update_element
> > > to text_field_with_auto_complete to hook into the
> afterUpdateElement
> > > event, also adds :frequency for polling info.
> > >
> > > http://dev.rubyonrails.org/ticket/3353 - Adds unique ids to radio
> > > elements
> > >
> > > http://dev.rubyonrails.org/ticket/3313 - Modifies the
> regex to not
> > > nuke the
> > > - on a negative value (keeps IDs unique)
> > >
> > > http://dev.rubyonrails.org/ticket/3136 - Extends
> country_select to
> > > optionally include the country codes.
> > >
> > >
> > >
> > > I'll also have the date_helper patch updated to trunk
> tonight. Not
> > > sure what's wrong with it yet but bitsweat asked for
> updated tests
> > > against trunk so...
> > >
> > >
> > > Bob Silva
> > > http://www.railtie.net/
> > >
> > >
> > > _______________________________________________
> > > Rails-core mailing list
> > > Rails-core@lists.rubyonrails.org
> > > http://lists.rubyonrails.org/mailman/listinfo/rails-core
> > >
> >
> > _______________________________________________
> > Rails-core mailing list
> > Rails-core@lists.rubyonrails.org
> > http://lists.rubyonrails.org/mailman/listinfo/rails-core
>
> _______________________________________________
> Rails-core mailing list
> Rails-core@lists.rubyonrails.org
> http://lists.rubyonrails.org/mailman/listinfo/rails-core
>
_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core
