With all the talk of 1.1, and with all the patches being applied, I realized that my laziness (or lack of free time, depending on your perspective) means that my OpenBase database adapter will most likely not make it into 1.1. This is mainly because I never got around to making it a plugin so that it could be throughly tested by the OpenBase community before being committed. Well, I'm finally motivated...

Do you think the adapter is ready for 1.1? Are you prepared to maintain it? ;)

I'd prefer to include it in the release (perhaps with caveats?) if it's feature complete modulo migrations support. The Firebird adapter took a similar path into Rails 1.0.

I just ran the test suite against a fresh update of the trunk. After adding a couple of new test tables, there are still 0 errors, but the 9 known failures have increased to 19. There are just two causes:

* LIMIT and OFFSET are broken in OpenBase. And actually, the tests expecting 0 results when using LIMIT 0 will always fail. The guys at OpenBase feel that LIMIT 0 should be equivalent to not having a limit at all. That way you can be a little sloppy with SQL generation and always include the limit statement even when the user doesn't specify a limit.

* GROUP BY works a little strange in OpenBase. Some of the new tests for the :group option are failing. I may be able to overcome this if I look into it a little closer.

Of course, these failures are due to idiosyncrasies in OpenBase SQL that most OB guys are going to be expecting. They know they won't get the right values with :offset, and they tend to write their group by clauses in OB friendly ways. I have also fixed a couple minor bugs that I've come across in using the adapter for the last month.

So, in short ... yes, I think version 3 of the patch at ticket #3538 is "ready enough". I'm positive that it could stand some refactoring. This adapter was the first thing I ever wrote in Ruby. Yeah, I know, most people write a hello world program, or go through the blog screencast or something. I like the immersion approach. Anyway, I could have never gotten rails past my boss if it didn't work with his favorite database server. The adapter is 345 riveting lines if anyone needs some bedtime reading...

-Derrick Spell

_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core

Reply via email to