> Can somebody from the core team take a look at this patch and comment or 
> apply?

One thing that immediately strikes me is: Where are all the tests?
It's hard to have strong confidence in patches fixing this many things
without test coverage. Could you have a look at adding some tests to
ensure that this works? Perhaps others in need of AWS could help?
--
David Heinemeier Hansson
http://www.loudthinking.com -- Broadcasting Brain
http://www.basecamphq.com   -- Online project management
http://www.backpackit.com   -- Personal information manager
http://www.rubyonrails.com  -- Web-application framework
_______________________________________________
Rails-core mailing list
[email protected]
http://lists.rubyonrails.org/mailman/listinfo/rails-core

Reply via email to