Yeah, you can't have a period in an Alias. I don't see how this would hurt anyone but maybe it would be better to replace the periods with underscores instead of loosing the owner name completely.

Jeff

Rick Olson wrote:
Can someone tell me why this patch is important? http://dev.rubyonrails.org/ticket/4251

"""
I think the name says it all.

Basically we are taking LEFT OUTER JOIN dbo.Users AS dbo.Users and
making it LEFT OUTER JOIN dbo.Users AS Users.
"""

Do the aliases cause issues if they have periods in them?  Would I be
potentially hurting folks using tables owned by different users?

FWIW it would probably be a simple change with the new #table_alias_for method:

http://dev.rubyonrails.org/browser/trunk/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb#L16

--
Rick Olson
http://techno-weenie.net
_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core

_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core

Reply via email to