On 3/26/06, Andrew Kaspick <[EMAIL PROTECTED]> wrote:
> On 3/26/06, Michael Koziarski <[EMAIL PROTECTED]> wrote:
> > > The reason I created this patch is explained in the ticket and that I
> > > figured the :include route was a bit cleaner from a users perspective
> > > than a combo of :select and :joins.
> >
> > The patch no longer applies cleanly, and seems to cause quite a few
> > failures (unless I've screwed up the merge).   Could you post an
> > updated version?  I'm happy to apply this if we can get it merged and
> > tested in time.
> >
> > --
> > Cheers
> >
> > Koz
>
> I'll take another look right away.  I know I received a conflict with
> it when I did an update today.
>
> I'll report back shortly.
>

I get the following without the patch...

test_create_table_with_binary_column(MigrationTest)
[./test/migration_test.rb:470]:
<""> expected but was
<nil>.

With the patch I seem to be getting 5 extra errors and the above
failure.  I'll look into the errors right now.
_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core

Reply via email to