Ha, just submitted that exact patch, #4626.

Rick Olson wrote:
"rick" made AR/Oracle cry...

What a wuss!  Here, try this:

Apparently, the oracle adapter doesn't like the fact that I used an
array to construct the calculations queries.

Index: lib/active_record/calculations.rb
===================================================================
--- lib/active_record/calculations.rb   (revision 4185)
+++ lib/active_record/calculations.rb   (working copy)
@@ -145,7 +145,7 @@
       protected
         def construct_calculation_sql(aggregate, aggregate_alias,
options) #:nodoc:
           scope = scope(:find)
-          sql  = ["SELECT #{aggregate} AS #{aggregate_alias}"]
+          sql  = "SELECT #{aggregate} AS #{aggregate_alias}"
           sql << ", #{options[:group_field]} AS
#{options[:group_alias]}" if options[:group]
           sql << " FROM #{table_name} "
           add_joins!(sql, options, scope)
@@ -154,7 +154,7 @@
           sql << " HAVING #{options[:having]}" if options[:group] &&
options[:having]
           sql << " ORDER BY #{options[:order]}" if options[:order]
           add_limit!(sql, options)
-          sql.join
+          sql
         end

         def execute_simple_calculation(operation, column_name,
column, aggregate, aggregate_alias, options) #:nodoc:

--
Rick Olson
http://techno-weenie.net
_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core


_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core

Reply via email to