The implementation involves some funky regex's on the sql sent along to the connection adapter, so I'm going to do some more extensive testing within my own app before posting to Trac.
I like the idea, however perhaps it's not ambitious enough? If instead of doing the value interpolation immediately, we could hold off and pass the full sql string down to the adapter. ["FULL SQL STRING", bunch, of, values] I've heard from thoughtworks that the performance difference for oracle is appreciable. It's probably true for other DBs too. The largest benefit though would be allowing people to insert huge blobs without a ... 65k sql statement.
A few questions though: 1. I'll fix any issues I find, but since this is done by post-processing the sql there's a chance that some funky hand-coded sql could make this fail. So I'm thinking about making this a configurable option -- #enable_oci_binding or somesuch. Thoughts? 2. Do other db's support a similar concept with a similar benefit? Should this functionality be implemented at a higher level (ie., in the abstract adapter) to make it usable for other dbs? As an aside, only the pretty comprehensive AR unit tests make a patch like this even possible to think about. So kudos to everyone on that point. _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
-- Cheers Koz _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
