Hampton,

Thanks for your testing on this. It does appear that :id, at least, is extra sticky now. We'll see what can be done with this, since it should definitely not be acting so zealous.

- Jamis

On Jun 1, 2006, at 12:58 PM, Hampton wrote:

Further:

I was trying to fix my code to use the nil method, and here was the result:

url_for(:page_number => 3, :id => nil)

"/video/2?id="

That's definitely not the desired behaviour.

-hampton.

On 6/1/06, Hampton <[EMAIL PROTECTED]> wrote:
Let me give you a more full example of what changes after the upgrade. I fully acknowledge this is a hackish way to keep a pretty URL. Whether this is the Best Way doesn't really matter. What should matter is that this breaks applications.

Routing in question:

map.connect ':controller/:page_number',
              :requirements => { :page_number => (/^[0-9]+$/) }

We start on a page with the url

{"action"=>"index", "id"=>"21", "controller"=>"video"}
or
/video/index/21

Then, during the rendering of this page, url_for is called as...

url_for(:page_number => 3)

As of revision 4340ish, this would translate into (good thing in my application!)

"/video/3"

As of the current revision, this translates into

"/video/3?id=21"

Certainly I can re-code things to work with the new revision, but if backwards compatibility is important then this shouldn't happen.

-hampton.



_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core

_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core

Reply via email to