Brad, This exact question was posed to the Rails Core team at the Q and A session at RailsConf. Basically the anwser was:
1) Include documentation and describe WHY this needs to be done. 2) Include tests 3) Make the patch small if possible. I think there were a few more things mentioned but that is all I can recall off the top of my head. Hope this helps, Zack On 6/27/06, Brad Ediger <[EMAIL PROTECTED]> wrote:
I think quite a few of us have been lurking on rails-core waiting for our pet patches to come through. The actual commit process seems rather opaque after a ticket is put into Trac. Would one of the core team members care to take a few minutes and explain how the process of getting a patch accepted works? Some tips on rails-core etiquette would be appreciated, also. It seems like many of us are anxious to get feedback (positive or negative) on our patches, but don't want to seem pushy by posting to the list every time we put something in Trac. I realize you guys are busy -- thanks! -- Brad Ediger Madriska Media Group Charles O Nutter wrote: > I've posted a couple different patches to ticket 4440, and as far as I > can tell they resolve all nonstandard block syntax throughout the > rails/railties module. I would be very interested in helping to move > this forward, since JRuby currently requires this patch for Rails to work. > > What's the next steps for this ticket? Are the patches satisfactory? > > -- > Charles Oliver Nutter @ headius.blogspot.com <http://headius.blogspot.com> > JRuby Developer @ www.jruby.org <http://www.jruby.org> > Application Architect @ www.ventera.com <http://www.ventera.com> > > > ------------------------------------------------------------------------ > > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
_______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
