Michael Schoen wrote:
"bitsweat" has given AR/Oracle some love, but it's still unhappy...

http://dev.rubyonrails.org/changeset/4574

Thanks for applying the patch. One diff (below) was left out though, which is why the test is still failing. Using find_every().first skips the unnecessary (in this case, since this is within #find_one and the condition is a single value for the primary key) limit option, which is both slightly faster for Oracle, and allows for pessimistic locking.

Index: activerecord/lib/active_record/base.rb
===================================================================
--- activerecord/lib/active_record/base.rb      (revision 4577)
+++ activerecord/lib/active_record/base.rb      (working copy)
@@ -981,7 +981,7 @@
-          if result = find_initial(options)
+          if result = find_every(options).first
_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core

Reply via email to