Even though I wrote it, this patch actually shouldn't be applied. Date helper should definately be refactored, but the smaller fixes should go in first. There are nasty bugs in the patch logic that surface on some edge cases (I don't remember what they are now).
I did up an article on one way to handle the bad date exceptions here. http://i.nfectio.us/articles/2006/02/22/handling-invalid-dates-with-activere cord-date-helpers I work with a lot of dates in my applications and I moved completely away from Rails dates in favor of JS-based calendars, hidden fields and strftime after futzing with Rails dates for awhile. I would suggest core mark the patch wontfix with a PDI on breaking it up into smaller fixes. Then plan a refactored version for 2.0. Bob Silva http://i.nfectio.us/ > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:rails-core- > [EMAIL PROTECTED] On Behalf Of Thijs Cadier > Sent: Thursday, July 13, 2006 6:33 AM > To: rails-core@lists.rubyonrails.org > Subject: [Rails-core] date_helper megapatch > andMultiparameterAssignmentErrors > > Hello all, > > There's a great patch in trac that fixes a lof of issues with the > date helpers. I'm afraid it hasn't had any attention yet. > > http://dev.rubyonrails.org/ticket/3811 > > This fixes all the little date_helper problems, except one: When you > choose an invalid date ActiveRecord throws an > ActiveRecord::MultiparameterAssignmentErrors. This used to work in > 1.0, Februari 30th would be translated to March 2nd. I have no clue > on how this could be fixed since the Error is thrown deep inside. I > was going to create a ticket for this, but Trac isn't working to well > at the moment. > > It would be great if the date_helpers could get some love, they're > basically broken and useless in the current state. Is there any core > member out there who could take a look at this? > > > Thanks, > > Thijs Cadier > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
