Haha.. it kinda makes sense, since the semicolon is breaking a line..
I guess my reason for the patch was that there is inconsistency across rails, with a mix of then, colon, semicolon, and newline.. any thoughts on what it should be? On 7/31/06, Nicholas Seckar <[EMAIL PROTECTED]> wrote:
Damn that's ugly. I'd rather stay on 1.8.4... On 7/31/06, Courtenay <[EMAIL PROTECTED]> wrote: > When running ruby 1.8.5 (latest, stable) a bunch of warnings show up. activerecord/lib/active_record/connection_adapters/oracle_adapter.rb:500: warning: colon will be obsoleted; use semicolon It seems that edge ruby wants this form for case statements: case stuff when 5; something when 6; something_else end This patch addresses this issue, as well as cleaning up a bunch of inconsistent conditional code style (mainly, stripping out 'then' in the few places it occurred) ________ courtenay http://caboo.se @o O@ _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
_______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
