Thank you for reviewing this PR another time.
> some icons are too dark, I inverted and hue-rotated them; here it's not done
> I suppose; see place_of_worship icon for an extreme example
Agree, that's also something I've noticed. I'm pushing another commit now which
should improve the situation. As a general remark, I would leave that sort of
fine tuning to a follow up pull request.
> do we need a smaller icon for waste baskets here just because it's smaller on
> the map render?
Yes, it matches exactly the size you see on the map.
> alignment wasn't great before, here it's even worse, see traffic lights for
> example
I've checked all 219 SVGs, and found that less than 10 of them might need some
fine tuning. The vast majority of new SVGs is just fine. Hence, I think that's
a good topic for follow up pull requests as well.
> I still think it's
> https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2298987792
> to switch to <img>s first, then start replacing them with svgs, assuming all
> of the images have the same size. Hopefully we can avoid random pixel offsets
> in css.
I'm not entirely clear what you're suggesting here. Assuming we need convert
SVGs to PNGs and maintain new entries in browse.scss for them, that would be a
very clear no-go for me. Speaking of experience in this PR, it's creating a
huge effort with very limited options for later reuse.
I would suggest to focus on any remaining import issues with SVGs instead in
this PR, rather than spending time on PNGs which we want to phase out anyway.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2365289785
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5080/c2365289...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
