My goal was to remove the activerecord-import gem by a built in equivalent
method. Since the validations are not automatically executed anymore, I added
the call to the validate method. Rubocop is not clever enough to figure out
that we're validating the model contents earlier on, so we need an additional
annotation. I really don't have an issue with that.
Now we could of course further change the implementation and get rid of the
model instances. However, that's a second step, and not needed to replace
activerecord-import. That's not to say that this isn't a valid discussion to
have, it just doesn't fit well here.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5038#issuecomment-2376366133
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5038/c2376366...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
