> ... A "fixup commit" is a commit that's added to a pull request that fixes
> problems with code introduced in the same pull request.
>
> From CONTRIBUTING.md (emphasis added)
>
> > Avoid including "fixup" commits ...
Is catching "fixup" commits (a line added (removed) in one commit and then
removed (added) in a subsequent commit within the same PR) using a `danger
workflow` something that could help maintainers? It’s a bit tricky to define
what constitutes a "fixup" because, if a commit represents a logical unit, a
line could have meaning in one commit but not necessarily in another, thus
justifying its removal.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5314#issuecomment-2490857226
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5314/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
