Here is the latest update with removed validation (which allows k and v to be
empty strings, like they can be in e.g. [this
node](https://www.openstreetmap.org/node/9842077514) (@kcne thanks for helping
in catching this). I haven't added other stuffs (composite index - this will be
part of separate PR, pulling out shared routine for writing tags - somehow this
doesn't affect readability to me, but we could pull it out for all elements in
a separate PR), but can add them if others request.
@tomhughes @gravitystorm @AntonKhorev can you, please, share your thoughts
about this PR and a way it solves the problem? If we want to do it in a proper
way, we will need to pass XML / JSON as a payload, but the problem with this
approach is we'll either break backward compatibility or would need to create
additional route which will work in a new way (this looks a little bit dirty to
me and more like a workaround than a proper way). What is the preferred way for
you at the moment (the current one in this PR or passing XML/JSON as a payload
using separate route) or can you suggest some other better solution?
Thanks,
Nenad.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5344#issuecomment-2520301211
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5344/c2520301...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
