I thought about this again and versioned notes may be what we actually want. We
already kind of have note versions, they only contain state changes (open ->
closed -> open again). But with tags we might want to record tag changes too.
Being able to change tags allows to use them for more than just recording what
tool the note was created with. We may want to use them for some kind of
categorization (like "needs survey"). We might want to add some categories to
already existing notes. Also we might want to add them to our own newly created
notes because the tools we were using to create these notes don't allow adding
tags or it was inconvenient to add the tags at the moment.
> tags associated with comments should not replace the original ones
We don't have *tags associated with comments* anywhere else on the site.
> they need to be "per interaction" so not just for the original note creation
> but at least for every comment
And what's the goal of that? Is it that important to record a client if it was
just a comment? We're not adding tags to changeset comments and not trying to
record clients in some other way, should we start doing that?
> and maybe for opening and closing too
This is different to commenting. If anyone actually modifies the note, we might
want to record that by adding a tag such as `edited_by` or `closed_by` or maybe
even by overwriting `created_by`. Although in the latter case maybe we
shouldn't be using `created_by` for notes at all (#5344 currently does), and
just use `edited_by`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-2538781672
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/issues/5294/2538781...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
