Updated the code again, resolved some issues raised here. Few remarks:

> CSP violations, days of week won't be visible if not resolved:
> 
> > Content-Security-Policy: (Report-Only policy) The page’s settings would 
> > block an inline style (style-src-attr) from being applied
> 
> ![image](https://private-user-images.githubusercontent.com/4158490/399146508-63e176b4-22d8-4238-9d3c-101a1cd06332.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzc3MzM1NTAsIm5iZiI6MTczNzczMzI1MCwicGF0aCI6Ii80MTU4NDkwLzM5OTE0NjUwOC02M2UxNzZiNC0yMmQ4LTQyMzgtOWQzYy0xMDFhMWNkMDYzMzIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDEyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAxMjRUMTU0MDUwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDhmOTIwM2Y2NzllNWI0ZjIwMmJkYjFjYjY1YWE4NDQzOTJhNGRkM2NhNjhhZDJmMWY5YWZhN2Y4MjQ5ZmQyZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.EoL-EszNCUum1gnFkRiUnrIKw93dYJSdCIw2RcnULms)

The issue was caused by the `CalendarLabel` plugin. Given the simplicity of our 
use case, I opted to convert the labels to use plain HTML/CSS instead of 
introducing custom CSP policies for controller/view/JS files. Labels should now 
display correctly, and the CSP violations should be resolved. Please let me 
know if there’s anything I might have missed.

> Is it the intended effect that nothing gets rendered in case the user made no 
> edits in the span of one year?

The heatmap now renders regardless of whether the user has made edits in the 
past year. If there’s interest in hiding the heatmap for users with no 
contributions, I can refactor it to include a fallback or placeholder message 
instead. Let me know your preference.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2612924757
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5402/c2612924...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to