@AntonKhorev commented on this pull request.


> +    1.upto(5).each do |n|
+      issue.reports << create(:report, :user => create(:user, :display_name => 
"Test Name #{n}"))
+    end

```suggestion
create_list(:report, 5, :issue => issue)
```
because you're not checking if usernames match `"Test Name #{n}"`.

And probably the same in the next test.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990#pullrequestreview-2575172169
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/4990/review/2575172...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to