Currently note markers in note layers don't necessarily display note 
descriptions. There's no check if the first "comment" returned by 
the api is a description or is it a regular comment because the description is 
hidden:

https://github.com/user-attachments/assets/50af9642-0067-4b9a-941e-64826c0271d0

I wrote this comment 
https://github.com/openstreetmap/openstreetmap-website/pull/5511#discussion_r1931817739
 where I say that it can be fixed by adding attributes to comments that 
indicate whether they are descriptions or actually comments. But that is not 
necessary because there's a status attribute, and if its value is `opened`, 
the "comment" is a description. This PR adds this check to note layer.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5576

-- Commit Summary --

  * Show only description as a marker tooltip in note layer

-- File Changes --

    M app/assets/javascripts/index/layers/notes.js (9)
    M test/application_system_test_case.rb (3)
    A test/system/note_layer_test.rb (40)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5576.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5576.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5576
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to