> The code changes here look great now but the commit history is rather messy - 
> can we get rid of the merges please and rebase it instead? and merge any 
> fixup commits into the thing they're fixing - having two `Refactor 
> embed.js.erb with layers.yml` commits in one PR can't be right.

Well, I tried to and failed miserably, as you may have seen. I fixed it in 
another branch, but as PRs can't have the source branch changed, I opened #5580.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5571#issuecomment-2628782011
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5571/c2628782...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to