@hlfan commented on this pull request.


> @@ -36,6 +36,9 @@ OSM.Directions = function (map) {
     OSM.DirectionsEndpoint(map, $("input[name='route_to']"), OSM.MARKER_RED, 
endpointDragCallback, endpointChangeCallback)
   ];
 
+  const exportGroup = L.layerGroup([...endpoints.map(m => m.marker), 
polyline]);
+  let downloadURL = null;
+

Well, this doesn't need to be done for every route displayed, so I want it to 
be outside of a function. For the download URL, I want to be able to revoke the 
last blob URL when creating the new one.
For now, I could drop the marker-color assignment or just export the polyline, 
as the pages linked in 
https://github.com/openstreetmap/openstreetmap-website/issues/5224#issuecomment-2362118967
 do.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5694#discussion_r1957919727
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5694/review/2620532...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to