@AntonKhorev commented on this pull request.


> @@ -80,6 +80,10 @@ OSM = {
 
     const hash = OSM.parseHash(location.hash);
 
+    const geoURI = Object.fromEntries(new URLSearchParams(
+      params.geouri?.replaceAll(/[?;]/g, "&")?.replaceAll(":", "=")

Are you sure you want `replaceAll(":", "=")`? Why do you need this replacement 
at all? What is going to happen on uris like 
`geo:323482,4306480;crs=EPSG:32618;u=20`?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2652302306
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5736/review/2652302...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to