@HolgerJeromin commented on this pull request.
> + $(L.SVG.create("svg"))
+ .append(
+ $(L.SVG.create("path")).attr("d", "M3 1s9 7 9 7c-1.056.587-2.112
1.173-3.168 1.76l3.031 6.615c.346.753.015 1.643-.738
1.989-.753.345-1.643.014-1.989-.739L6.201 11.221C5.134 11.814 4.067 12.407 3
13V1z"),
+ $(L.SVG.create("text")).text("?").attr({
+ "x": "12.5",
+ "y": "18.512",
+ "font-family": "Helvetica, sans-serif",
+ "font-weight": "Bold",
+ "font-size": "12"
+ })
+ )
+ .attr("fill", "currentColor")
+ .attr("class", "h-100 w-100")
+ .appendTo(link);
Is this easier to read?
```suggestion
$(`<svg>
<path d="M3 1s9 7 9 7c-1.056.587-2.112 1.173-3.168 1.76l3.031
6.615c.346.753.015 1.643-.738 1.989-.753.345-1.643.014-1.989-.739L6.201
11.221C5.134 11.814 4.067 12.407 3 13V1z" />
<text "x": "12.5" "y": "18.512"
"font-family"="Helvetica, sans-serif" "font-weight"="Bold" "font-size"="12"
"class"="h-100 w-100"
"fill"="currentColor"
>?</text></svg>`)
.appendTo(link);
```
Probably easier to process by the browser...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#pullrequestreview-2663551805
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5752/review/2663551...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
