@hlfan commented on this pull request.


> @@ -22,8 +18,11 @@
   <div class='col-sm'>
     <h3 class='fs-5'><%= t "site.welcome.add_a_note.title" %></h3>
     <p><%= t "site.welcome.add_a_note.para_1" %></p>
-    <p><%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon => 
tag.a(:class => "icon note bg-dark rounded-1",
-                                                                               
 :title => t("javascripts.site.createnote_tooltip")) %></p>
+    <p><%= map_hash = params[:lat].to_f && params[:lon].to_f ? 
"#map=#{params[:zoom].to_i || 17}/#{params[:lat].to_f}/#{params[:lon].to_f}" : 
""

I can't leave it unchanged as the JS uses the icon class; in an earlier 
iteration, I did cd1a05af94e88053c24f56404bd03418d2568bc0 instead. Would this 
work better?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r2029932138
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5752/review/2744954...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to