@tomhughes commented on this pull request.

Technically this looks so I think the main questions here will be whether (a) 
people think it's a good idea and (b) whether these are the best colour choices.

> @@ -1,15 +1,40 @@
 OSM.HistoryChangesetsLayer = L.FeatureGroup.extend({
-  _changesets: [],
+  newerColor: "#AA8866",
+  olderColor: "#8888AA",

If we're going to use named constants for these colours shouldn't we do it for 
the others as well?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5924#pullrequestreview-2762728126
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5924/review/2762728...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to