The previous method relied on intersection events for all changeset list items that go from below the viewport to above the viewport or in the opposite direction. But that required the items to enter the viewport in between. This is not guaranteed to happen if the sidebar contents is scrolled fast enough, for example by dragging the scrollbar or pressing Home/End keys. If an item goes from below straight to above without ever being inside the viewport, no intersection event is generated and the changeset is left in an invalid state with wrong color.
This fix updates changesets below/above based on changesets inside the viewport. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5935 -- Commit Summary -- * Fix marking changesets outside of viewport on history pages -- File Changes -- M app/assets/javascripts/index/history-changesets-layer.js (6) M app/assets/javascripts/index/history.js (15) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5935.patch https://github.com/openstreetmap/openstreetmap-website/pull/5935.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5935 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
