hlfan left a comment (openstreetmap/openstreetmap-website#5938)
Neither.
You already optimized the SVGs when you added them into the templates[^1]. The
additional `xmlns` is only for increased compatibility during development.
Pulling the SVGs out increases the visualizability (file thumbnails you
wouldn't get when they're packed into templates) and supports the _separation
of concerns_ raised in the original issue.
Just because _you_ understand both SVG internals and layout doesn't mean every
contributor should have to.
By keeping them separated, layout edits don’t require SVG expertise, and SVG
tweaks won’t accidentally break the layout.
[^1]: see, e.g., the original
[new.svg](https://github.com/openstreetmap/openstreetmap-website/blob/f9db802c7b2f8ee9582cb2c9f7196d6abafdfced/app/assets/images/new.svg)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5938#issuecomment-2813560815
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5938/c2813560...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
