HarelM left a comment (openstreetmap/openstreetmap-website#5943)

I've added some tests according to what I saw in other controllers' tests.
Let me know if more tests are needed.

As to contributing, I think it's missing some explanation of default users that 
are automatically created and how to login to those (like the nobody user). And 
how to create users in case those are needed.

How to boot the app and see that everything is working as expected might need 
to be a bit more explicitly written I think.

I can open a PR against the contributing.md for what I think might help future 
developers if that might be of interest. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943#issuecomment-2822498239
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5943/c2822498...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to