<!--
Please read the contributing guidelines before making a PR:
  
https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md

Pay particular attention to the section on how to present PRs:
  
https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#pull-requests
-->

### Description
The `gravatar_enable` method configures a gravatar for the user. Since this is 
business logic let's put it on the model instead of in the controller. This 
also opens the door to testing this method outside of the request/response 
lifecycle.

### How has this been tested?
The existing test coverage in `ConfirmationsController` continues to pass.


You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5988

-- Commit Summary --

  * Move gravatar_enable method to User model

-- File Changes --

    M app/controllers/confirmations_controller.rb (24)
    M app/models/user.rb (20)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5988.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5988.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5988
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to