Currently highlighted in-viewport bboxes change their color to more reddish. Changing their color made sense previously when only one orange color was in use. However now we have different colors, with red being for newer changesets. The problem is that if the highlighted changeset is located on a pile of newer changesets, it's made less noticeable by this color change. I think it's better to do highlights by other means without color changes. In this PR I'm making highlighted outlines bolder fo in-viewport changesets.
Before / after:   This should especially helpful for valious cases of color blindness. Before / after for completely colorblind users:   But I had to do one more thing. Changing the color still made highlighted changesets stand out more among other in-viewport changesets, compared with same color + bolder outline. To compensate for keeping the same color I added shadows to highlighted changesets. This should make sense because they are displayed "above" the rest. Initially I wanted a light shadow, like I do for sticky close buttons, and that's what the PR still has for out-of-viewport changesets. However for in-viewport changesets that wasn't enough and I gave them heavier shadows. Before / after:   You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5993 -- Commit Summary -- * Split changeset highlight back layer into area and outline * Make highlight outline bolder for in-viewport changesets * Remove reddish-orange highlight color from in-viewport changesets * Add shadows to changeset highlights -- File Changes -- M app/assets/javascripts/index/history-changesets-layer.js (30) M app/assets/stylesheets/common.scss (9) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5993.patch https://github.com/openstreetmap/openstreetmap-website/pull/5993.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5993 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
