@tomhughes commented on this pull request.


> @@ -2,6 +2,7 @@ class UsersController < ApplicationController
   include EmailMethods
   include SessionMethods
   include UserMethods
+  include HeatmapHelper

This should probably be a `HeatmapMethods` concern rather than a helper - 
helpers are primarily about adding methods to view, where they are made 
available automatically, while concerns are about extending models and 
controllers.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6018#pullrequestreview-2848284315
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6018/review/2848284...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to