@tyrasd commented on this pull request.
> @@ -7,5 +7,5 @@
data[:zoom] = @zoom if @zoom
data[:gpx] = trace_data_url(params[:gpx], :format => :xml) if params[:gpx]
data[:url] = id_url(:locale => params[:locale]) %>
- <%= tag.iframe "", :frameBorder => 0, :id => "id-embed", :class => "w-100
h-100", :allowfullscreen => "", :data => data %>
+ <%= tag.iframe "", :frameBorder => 0, :id => "id-embed", :class => "w-100
h-100", :allowfullscreen => true, :autofocus => true, :data => data %>
PS: I've also changed the boolean attribute `allowfullscreen` to `true` as
[recommended](https://api.rubyonrails.org/v8.0.2/classes/ActionView/Helpers/TagHelper.html)
in the docs.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6083#pullrequestreview-2895614691
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6083/review/2895614...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
