@hlfan commented on this pull request.


> @@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg"; width="16" height="16" 
fill="currentColor" viewBox="0 0 16 16">

I see you also removed the "bi" classes that Bootstrap uses to set the icon 
size to the font size that would set the size for you.

`xmlns` isn't needed when part of an HTML file, but for standalone files, as 
they are stored, ["an SVG namespace declaration must be provided so that all 
SVG elements are identified as belonging to the SVG 
namespace."](https://www.w3.org/TR/SVG/struct.html#Namespace)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6216#discussion_r2222303209
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6216/review/3042666...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to