@hlfan commented on this pull request.


> @@ -4,6 +4,7 @@
   nameId: "standard"
   canEmbed: true
   canDownloadImage: true
+  formats: [png, jpeg, webp, svg, pdf]

You add this for JS, but the select options are still hard-coded:
```erb
        <%= all_formats = @downloadable_layers.flat_map { |layer| 
layer["formats"] }.uniq
            select_tag("mapnik_format",
                       options_for_select(all_formats.map { |f| [f.upcase, f] 
}),
                       { :class => "form-select w-auto", :required => true }) %>
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#pullrequestreview-3042858885
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6192/review/3042858...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to