Map XML download currently has a few issues, such as a button staying in disabled state after a download, or error messages that are shown on a blank page.
Applying the same concepts as in #6192, this PR aims at making the download a bit more robust and user friendly. We have a bit of code duplication here, and it would probably make sense to move downloadBlob, handleExportError and turbo:submit-end handler to a common file. Any ideas? You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6255 -- Commit Summary -- * Fix map xml download -- File Changes -- M app/assets/javascripts/index/export.js (50) M app/views/site/export.html.erb (4) M config/locales/en.yml (1) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6255.patch https://github.com/openstreetmap/openstreetmap-website/pull/6255.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6255 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/6...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
