@tomhughes commented on this pull request.
> }
OSM.getTurboBlobHandler = DownloadUtil.getTurboBlobHandler;
+ OSM.getHtmlResponseHandler = DownloadUtil.getHtmlResponseHandler;
I was thinking much the same things when I looked at this, namely why are we
defining things in a private class and them immediately exporting them to the
global namespace, and why are we using an IIFE for things in the global
namespace.
I guess if the class remains private the `getTurboBlobHandler` at least would
have to remain in the IIFE even if was moved outside the class as it needs to
reference it.
I don't think any of this is a show stopper in any case.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6284#discussion_r2249999654
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6284/review/3082200...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
