tomhughes left a comment (openstreetmap/openstreetmap-website#6302)
Speaking as the review of #6271 the declared purpose of that PR was moving
styling from CSS to bootstrap classes rather than any optimisation of the CSS
itself.
It was also essentially impossible to do a detailed code review of it, or it
would have taken an unreasonable amount of time for me to go and read up on
what each bootstrap class that was added did and correlate that to removed CSS
and vice versa.
So review was largely based on a visual inspection of the site with the PR
merged to check that there were no obvious issues in the areas of the site
affected by the changes, so mostly I was concerned with the header and the
search bar and so on. I probably only looked at a normal browser and not a
mobile size though. Also I had probably already cancelled any banners on my
browser so wouldn't have seen them again.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6302#issuecomment-3165133850
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6302/c3165133...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
