@tomhughes commented on this pull request.
> + @ways = @changeset.old_ways
+ .order(:way_id, :version)
+ .offset(ELEMENTS_PER_PAGE * (@current_way_page - 1))
+ .limit(ELEMENTS_PER_PAGE)
+ end
+
+ def load_relations
+ @relations_count = @changeset.actual_num_changed_relations
+ @current_relation_page = params[:relation_page].to_i.clamp(1,
element_pages_count(@relations_count))
+ @relations = @changeset.old_relations
+ .order(:relation_id, :version)
+ .offset(ELEMENTS_PER_PAGE * (@current_relation_page
- 1))
+ .limit(ELEMENTS_PER_PAGE)
+ end
+
+ helper_method def element_pages_count(elements_count)
Oh that's interesting about `def` and something I didn't know! I guess there's
no reason not to do it this way.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6316#discussion_r2274073254
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6316/review/3116908...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
