@tomhughes commented on this pull request.
> @@ -0,0 +1,13 @@
+<turbo-frame id="<%= frame_id %>">
+ <% if relation.redacted? && !params[:show_redactions] %>
Can this ever happen? If it's redacted and we're not showing redactions then we
won't have generated the frame will we?
I guess there's an issue that somebody could request the frame manually to try
and see the redactions but the controller could just reject requests for a
frame for a redacted relation unless the show redactions flag is set?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6326#pullrequestreview-3126427501
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6326/review/3126427...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
