@hlfan commented on this pull request.


> @@ -29,6 +29,8 @@ L.OSM.share = function (options) {
 
     $ui.find(".share-tab [id]").on("click", select);
 
+    $("#geo_uri").on("mouseover click focus", askToHandleGeoURI);

I wanted to make it as non-intrusive as possible while not cluttering up the 
pane more. Also, afaik, a button couldn't trigger the registration for the 
webmanifest-variant. But the layout shift from Firefox makes this 
unacceptable...

A by-default hidden button would be nice, but there isn't a way to figure out 
if the site already has the handler registered.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5968#discussion_r2304267083
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5968/review/3160260...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to