@pablobm commented on this pull request.


> @@ -17,5 +17,6 @@ class UserPreference < ApplicationRecord
   belongs_to :user
 
   validates :user, :associated => true
-  validates :k, :v, :length => 1..255, :characters => true
+  validates :k, :length => 1..255, :characters => true
+  validates :v, :length => 1..10_000, :characters => true

Since this is intended to store arbitrary, computer-readable data: does it make 
sense to have this restriction to `characters`? Would it make sense to allow 
any binary bytes?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6399#pullrequestreview-3273147488
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6399/review/3273147...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to