1ec5 created an issue (openstreetmap/openstreetmap-website#6444)
If a note’s author has been deleted, the note reads “unknown”. For example, the
user who left [this note](https://www.openstreetmap.org/note/1943905) got
deleted at some point. It definitely did contain content originally; otherwise,
I wouldn’t have had anything to respond to. I think the code intends to show a
different placeholder, “deleted”, so I’m not sure why it shows “unknown”
instead:
https://github.com/openstreetmap/openstreetmap-website/blob/320d2108df8f0436e8ad3b3d72e4a2be1658fbf4/app/helpers/note_helper.rb#L7-L13
https://github.com/openstreetmap/openstreetmap-website/blob/320d2108df8f0436e8ad3b3d72e4a2be1658fbf4/config/locales/en.yml#L3478-L3479
In any case, maybe it would be good to say explicitly that the note has been
deleted because its author has been deleted. The user might not understand that
on their own. We get a lot of single-word junk notes, so this can end up
looking like that too.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6444
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/issues/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
