@pablobm commented on this pull request.
> @@ -110,7 +110,7 @@ def test_openid_connect
end
assert_equal user.id.to_s, data["sub"]
- assert_not data.key?("preferred_username")
This assertion gives me pause, explicitly checking that the key is not present.
Waiting to see what others say. If this PR is rejected, at least we should add
an explanatory comment in this test.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6429#pullrequestreview-3303945202
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6429/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
